Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig: merge #522

Merged
merged 23 commits into from
Aug 30, 2021
Merged

sig: merge #522

merged 23 commits into from
Aug 30, 2021

Conversation

tisonkun
Copy link
Contributor

Signed-off-by: tison [email protected]

close #519

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winkyao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@tisonkun
sig: merge
6fb54d4 
Signed-off-by: tison <[email protected]>
tisonkun
tisonkun commented Aug 17, 2021
View reviewed changes
Copy link
Contributor Author

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request comes from #516 and trying to build a Lightweight and GitHub Friendly Special Interest Group. We name it as team to distinguish with the original name "SIG".

The origin of these files comes from "special-interest-group" memberships.

sig repos original
tidb tidb, parser, etc. sql-infra, planner, execution, parts of migration, etc.
deployment tidb-operator, tiup k8s, tiup
diagnositic tidb-dashboard diagnositic
migration dm, ticdc, etc. migrate
docs docs, docs-cn, docs-dm docs
bigdata tibigdata bigdata
postgresql as is postgresql
  • community-infra can be handled specifically as TiKV community did.
  • diagnostic dropped, pingcap/tidb-dashboard can join tidb sig.
  • web dropped as no activity, those repos can fallback to native GitHub collaboration.

I'd ask for all members listed here to verify whether you're still an active member or willing to mark yourself as an emeritus member so that prevent be listed as active reviewer / committer.

teams/bigdata/membership.json Outdated Show resolved Hide resolved
teams/tidb/membership.json Show resolved Hide resolved
teams/tidb/membership.json Outdated Show resolved Hide resolved
disksing
disksing reviewed Aug 17, 2021
View reviewed changes
teams/tidb/READNE.md Outdated Show resolved Hide resolved
@tisonkun
fix README typo
b87c841 
Signed-off-by: tison <[email protected]>
@lysu
Copy link

lysu commented Aug 17, 2021 •
edited
Loading

ps: does internal "bug jail group" for tidb also will be merge after this~?

kennytm
kennytm reviewed Aug 17, 2021
View reviewed changes
teams/migration/README.md Outdated Show resolved Hide resolved
breezewish
breezewish reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to remove HundunDM and baurine (from sig-diagnose) since their leader privilege is mainly under TiDB Dashboard repository, instead of TiDB。

teams/tidb/membership.json Outdated Show resolved Hide resolved
teams/tidb/membership.json Outdated Show resolved Hide resolved
@tisonkun
Copy link
Contributor Author

ps: does internal "bug jail group" for tidb also will be merge after this~?

I don't think so. At least I'm trying to decouple these two things. We will keep the label "sig/xxx" for a while, just it doesn't have the magic limit review / commit permission. "bug jail" can run as is since we don't change anything it depends on effectively.

@breezewish
Copy link
Member

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

@tisonkun
Copy link
Contributor Author

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

... leave the original name "diagnostic"?

@breezewish
Copy link
Member

It would also be great if tidb-dashboard has a standalone team, considering that actual members are mostly different from TiDB's. It is not appropriate for tidb-dashboard committers to have such high privilege in tidb and its friends repositories, and vise versa.

... leave the original name "diagnostic"?

looks good!

@tisonkun
Copy link
Contributor Author

@breeswish separated diagnostic team by 879a286

jackysp
jackysp reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the members of the transaction group. They also have code to review and commit. https://github.com/orgs/pingcap/teams/transaction-committers/members @tisonkun , thanks!

@tisonkun
Copy link
Contributor Author

@jackysp thanks for reminding me. Updated as 8fb7804

@tisonkun tisonkun mentioned this pull request Aug 18, 2021
Closed
@kennytm
Copy link
Contributor

kennytm commented Aug 19, 2021

@tisonkun some clarification questions on the future governance (the PR is empty on these, #516 doesn't help)

  1. Are SIGs going to be removed once Teams are up?
  2. All teams share the same promotion/demotion process? https://github.com/tikv/community/blob/master/GOVERNANCE.md
  3. Will there still be a need for per-team regular (bi/weekly) meetings?

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 19, 2021 •
edited
Loading

@kennytm thanks for your comment. I'm thinking of this and drafting a propose of governance bylaws so that we can discuss #519 and bylaws simultaneously.

Are SIGs going to be removed once Teams are up?

Yes as a governance unit. But domain experts exist objectively, their group can be named as SIG. That means we focus on purge SIG as a governance unit, but labels, slack channel remains as least for now.

All teams share the same promotion/demotion process?

Yes. In #516 it writes

Remain the consensus voting requirements. SIGs can generate their own guidelines on what they are looking for on committers etc. But hopefully we have loose requirements and contributors conclude how to become a committer by existing examples.

Also let the sig leaders moderate the whole promotion procedure.

I'm thinking of this and drafting a propose of governance bylaws so that we can discuss #519 and bylaws simultaneously, hopefully by the end of this weekend and we get a clear image.

Will there still be a need for per-team regular (bi/weekly) meetings?

No as a governance rule. If the team wants it, they can schedule by themselves, we don't require it.

@tisonkun
Copy link
Contributor Author

@kennytm as b1dcf5a.

I'm going to join community level decision making folder, team level decision making folder, and legacy rfcs as a follow up.

@tisonkun
kubernetes team
e1dd2ee 
Signed-off-by: tison <[email protected]>
sunxiaoguang
sunxiaoguang reviewed Aug 23, 2021
View reviewed changes
teams/README.md Outdated Show resolved Hide resolved
teams/README.md Outdated Show resolved Hide resolved
@tisonkun
address comments
bf479bb 
Signed-off-by: tison <[email protected]>
sunxiaoguang
sunxiaoguang approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

LGTM

@ti-chi-bot
Copy link
Member

@sunxiaoguang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Great work!

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

winkyao
winkyao approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2021
@tisonkun
Copy link
Contributor Author

Hi audience in this thread! I'm going to merge this PR next week as two of our toc members show positive reactions.

@Mini256 after this PR merged, we're going to build the GitHub teams based on the membership files and change the lgtm plugin with reviewer_team and cmmitter_team configs. Is the prerequisite prepared?

@Mini256
Copy link
Member

Mini256 commented Aug 26, 2021

@Mini256 after this PR merged, we're going to build the GitHub teams based on the membership files and change the lgtm plugin with reviewer_team and cmmitter_team configs. Is the prerequisite prepared?

I will finish the test for the new config options this week.

@tisonkun
Copy link
Contributor Author

@Mini256 thank you!

@tisonkun
Copy link
Contributor Author

Hi audience in this thread,

I'm going to merge this PR now, and later will update the mechanism with help by @Mini256 .

Thanks for all of your participant.

@tisonkun
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5697ba7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2021
@ti-chi-bot ti-chi-bot merged commit fe66c24 into pingcap:master Aug 30, 2021
tisonkun added a commit to tisonkun/community-1 that referenced this pull request Aug 30, 2021
@tisonkun
follow ups to pingcap#522
f31bbd1 
Signed-off-by: tison <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Aug 30, 2021
@tisonkun
follow ups to #522 (#532)
3af3b2a
@tisonkun tisonkun deleted the membership branch September 3, 2021 00:40
@tisonkun tisonkun mentioned this pull request Sep 6, 2021
Merged
12 tasks
@ekexium ekexium mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer left review comments

@disksing disksing disksing left review comments

@DanielZhangQD DanielZhangQD DanielZhangQD left review comments

@kennytm kennytm kennytm left review comments

@3pointer 3pointer 3pointer left review comments

@lilin90 lilin90 lilin90 left review comments

@qiancai qiancai qiancai left review comments

@overvenus overvenus overvenus left review comments

@breezewish breezewish breezewish left review comments

@siddontang siddontang siddontang left review comments

@AstroProfundis AstroProfundis AstroProfundis left review comments

@Ehco1996 Ehco1996 Ehco1996 left review comments

@jackysp jackysp jackysp left review comments

@nolouch nolouch nolouch left review comments

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special Interest Groups should never divide repository